Skip to content

Don't fetch block numbers nor check rpc version for ignored tests #3742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Oct 16, 2025
Merged

Don't fetch block numbers nor check rpc version for ignored tests #3742

merged 18 commits into from
Oct 16, 2025

Conversation

@Abeeujah
Copy link
Contributor

@Abeeujah Abeeujah commented Sep 22, 2025 •
edited
Loading

Closes #1637

Introduced changes

Block number and RPC version for ignored tests is no longer being checked

  • fork_config returns None for ignored tests
  • should_be_run IgnoredFilter::Ignored match arm asserts that test case is ignored.

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@Abeeujah Abeeujah requested a review from a team as a code owner September 22, 2025 10:56
cptartur
cptartur requested changes Sep 24, 2025
View reviewed changes
cptartur
cptartur requested changes Sep 24, 2025
View reviewed changes
@Abeeujah Abeeujah requested a review from cptartur September 26, 2025 16:48
cptartur
cptartur reviewed Sep 29, 2025
View reviewed changes
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add some tests checking if fork configs get properly resolved (or not resolved) based on the ignored filter.

@Abeeujah Abeeujah requested a review from cptartur September 30, 2025 11:12
cptartur
cptartur reviewed Sep 30, 2025
View reviewed changes
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a bunch of tests is failing, not sure if due to changes from this PR. Maybe try updating from master

@Abeeujah
Copy link
Contributor Author

Abeeujah commented Oct 1, 2025

The failing tests seem to look like they all expect std contains some text... assert_stdout_contains

@Abeeujah Abeeujah requested a review from cptartur October 2, 2025 12:50
@cptartur
Copy link
Member

cptartur commented Oct 9, 2025 •
edited
Loading

The failing tests seem to look like they all expect std contains some text... assert_stdout_contains

I've double checked, the tests are failing because TestCaseWithResolvedConfig::new was replaced with direct creation of that struct. We cannot do that because new contains logic that sanitizes tests names – a necessary step for all test cases, otherwise they will contain _test_generated and _fuzzer_generated from our proc macros.

@Abeeujah
Copy link
Contributor Author

Abeeujah commented Oct 9, 2025

The failing tests seem to look like they all expect std contains some text... assert_stdout_contains

I've double checked, the tests are failing because TestCaseWithResolvedConfig::new was replaced with direct creation of that struct. We cannot do that because new contains logic that sanitizes tests names – a necessary step for all test cases, otherwise they will contain _test_generated and _fuzzer_generated from our proc macros.

You're right, Instantiating with new solves it.

cptartur
cptartur reviewed Oct 14, 2025
View reviewed changes
@Abeeujah Abeeujah requested a review from cptartur October 15, 2025 13:26
cptartur
cptartur approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left one more comment.

Let's wait for someone else from the team to review it as well.

@cptartur cptartur added this pull request to the merge queue Oct 16, 2025
Merged via the queue into foundry-rs:master with commit 9434744 Oct 16, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddoktorski ddoktorski ddoktorski approved these changes

@cptartur cptartur cptartur approved these changes

@MKowalski8 MKowalski8 Awaiting requested review from MKowalski8 MKowalski8 is a code owner automatically assigned from foundry-rs/starknet-foundry

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't fetch block numbers nor check rpc version for ignored tests when no --ignored nor --include-ignored flag is specified

3 participants

@Abeeujah @cptartur @ddoktorski